Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add Virtual Machine Scale Set scanner #208

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

vanwinkelseppe
Copy link
Contributor

@vanwinkelseppe vanwinkelseppe commented Apr 23, 2024

Description

Added a basic rule set for Virtual Machine Scale sets

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #108

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Run listing
  • Unit tests passing

@vanwinkelseppe
Copy link
Contributor Author

Run documentation command after other merges have happened: @vanwinkelseppe

@vanwinkelseppe
Copy link
Contributor Author

@cmendible Updated documentation and rebased of main! Ready for review

internal/scanners/vmss/rules.go Outdated Show resolved Hide resolved
@cmendible
Copy link
Member

@vanwinkelseppe please rebase an re-generate the rules docs so I can merge this one.

@vanwinkelseppe vanwinkelseppe force-pushed the features/vmss branch 2 times, most recently from f69256a to 2ef3529 Compare April 25, 2024 07:18
@vanwinkelseppe
Copy link
Contributor Author

@vanwinkelseppe please rebase an re-generate the rules docs so I can merge this one.

@cmendible done!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 37.68116% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 46.67%. Comparing base (d82d313) to head (4ecea13).
Report is 20 commits behind head on main.

Files Patch % Lines
internal/scanners/vmss/vmss.go 0.00% 40 Missing ⚠️
internal/scanners/vmss/rules.go 89.65% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   48.44%   46.67%   -1.77%     
==========================================
  Files          72       76       +4     
  Lines        3625     3921     +296     
==========================================
+ Hits         1756     1830      +74     
- Misses       1854     2075     +221     
- Partials       15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmendible cmendible merged commit e0de39d into Azure:main Apr 25, 2024
12 checks passed
@vanwinkelseppe vanwinkelseppe deleted the features/vmss branch April 25, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Azure VM Scale Set scanner
3 participants