Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing vm az check #235 #236

Merged
merged 1 commit into from
May 9, 2024
Merged

fixing vm az check #235 #236

merged 1 commit into from
May 9, 2024

Conversation

cmendible
Copy link
Member

Description

fixing VMs Availability Zone check

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #235

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.79%. Comparing base (d82d313) to head (c6f14f9).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   48.44%   46.79%   -1.66%     
==========================================
  Files          72       78       +6     
  Lines        3625     4020     +395     
==========================================
+ Hits         1756     1881     +125     
- Misses       1854     2123     +269     
- Partials       15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmendible cmendible merged commit 67e431d into main May 9, 2024
12 checks passed
@cmendible cmendible deleted the issue-235 branch May 9, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual Machine should have availability zones enabled showing as not compliant.
2 participants