Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalized location and fixed some rules #80

Merged
merged 3 commits into from
May 19, 2023
Merged

Normalized location and fixed some rules #80

merged 3 commits into from
May 19, 2023

Conversation

cmendible
Copy link
Member

@cmendible cmendible commented May 19, 2023

Description

Normalized location and fixed:

  • SLA for RAGZRS storage
  • AKS should integrate authentication with AAD (Managed)

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

@cmendible cmendible self-assigned this May 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #80 (384597c) into main (f32a8ab) will increase coverage by 0.07%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   40.18%   40.25%   +0.07%     
==========================================
  Files          46       46              
  Lines        2618     2618              
==========================================
+ Hits         1052     1054       +2     
+ Misses       1532     1530       -2     
  Partials       34       34              
Impacted Files Coverage Δ
internal/scanners/st/rules.go 82.08% <66.66%> (+2.98%) ⬆️
internal/scanners/aks/rules.go 88.39% <100.00%> (ø)

@cmendible cmendible changed the title Normalized location and fixed SLA for RAGZRS storage Normalized location and fixed some rules May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants