Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some typos #89

Merged
merged 1 commit into from
Jun 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/scanners/agw/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func (a *ApplicationGatewayScanner) GetRules() map[string]scanners.AzureRule {
Id: "agw-001",
Category: scanners.RulesCategoryReliability,
Subcategory: scanners.RulesSubcategoryReliabilityScaling,
Description: "Application Gatewway: Ensure autoscaling is used with a minimum of 2 instances",
Description: "Application Gateway: Ensure autoscaling is used with a minimum of 2 instances",
Severity: scanners.SeverityCritical,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
g := target.(*armnetwork.ApplicationGateway)
Expand All @@ -31,7 +31,7 @@ func (a *ApplicationGatewayScanner) GetRules() map[string]scanners.AzureRule {
Id: "agw-002",
Category: scanners.RulesCategorySecurity,
Subcategory: scanners.RulesSubcategorySecuritySSL,
Description: "Application Gatewway: Secure all incoming connections with SSL",
Description: "Application Gateway: Secure all incoming connections with SSL",
Severity: scanners.SeverityHigh,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
g := target.(*armnetwork.ApplicationGateway)
Expand All @@ -53,7 +53,7 @@ func (a *ApplicationGatewayScanner) GetRules() map[string]scanners.AzureRule {
Id: "agw-003",
Category: scanners.RulesCategorySecurity,
Subcategory: scanners.RulesSubcategorySecurityFirewall,
Description: "Application Gatewway: Enable WAF policies",
Description: "Application Gateway: Enable WAF policies",
Severity: scanners.SeverityHigh,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
g := target.(*armnetwork.ApplicationGateway)
Expand All @@ -66,7 +66,7 @@ func (a *ApplicationGatewayScanner) GetRules() map[string]scanners.AzureRule {
Id: "agw-004",
Category: scanners.RulesCategoryReliability,
Subcategory: scanners.RulesSubcategoryReliabilitySKU,
Description: "Application Gatewway: Use Application GW V2 instead of V1",
Description: "Application Gateway: Use Application GW V2 instead of V1",
Severity: scanners.SeverityHigh,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
g := target.(*armnetwork.ApplicationGateway)
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/scanner.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ const (
RulesCategorySecurity = "Security"
RulesCategoryCostOptimization = "Cost Optimization"
RulesCategoryOperationalExcellence = "Operational Excellence"
RulesCategoryPerformanceEfficienccy = "Performance Efficienccy"
RulesCategoryPerformanceEfficienccy = "Performance Efficiency"

RulesSubcategoryReliabilityAvailabilityZones = "Availability Zones"
RulesSubcategoryReliabilitySLA = "SLA"
Expand Down