Skip to content

Commit

Permalink
[SQL] BREAKING CHANGE: az sql db create: Remove WideWorldImportersStd…
Browse files Browse the repository at this point in the history
… and WideWorldImportersFull as allowed values for --sample-name values (#11976)

* Remove WideWorldImporters as allowed values for sql db sample name

The WideWorldImportersStd and WideWorldImportersFull sql db samples were never supported in production and were only documented here by mistake. Removing them from allowed values so that users do not attempt to create them. Note that this is not a breaking change because these options already caused db creation to fail.

* format history

Co-authored-by: Zunli Hu <zuh@microsoft.com>
  • Loading branch information
jaredmoo and Juliehzl committed Jan 30, 2020
1 parent f41a7de commit 72a7e1f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions src/azure-cli/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ Release History

* Added new commands `az atp show` and `az atp update` to view and manage advanced threat protection settings for storage accounts.

**SQL**

* [BREAKING CHANGE] `az sql db create`: Remove "WideWorldImportersStd" and "WideWorldImportersFull" as documented allowed values for "az sql db create --sample-name". These sample databases would always cause creation to fail.

**Storage**

* Add a new command group `az storage share-rm` to use the Microsoft.Storage resource provider for Azure file share management operations.
Expand Down
4 changes: 3 additions & 1 deletion src/azure-cli/azure/cli/command_modules/sql/_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -419,9 +419,11 @@ def load_arguments(self, _):
arg_group=creation_arg_group,
arg_type=get_enum_type(CatalogCollationType))

# WideWorldImportersStd and WideWorldImportersFull cannot be successfully created.
# AdventureWorksLT is the only sample name that is actually supported.
c.argument('sample_name',
arg_group=creation_arg_group,
arg_type=get_enum_type(SampleName))
arg_type=get_enum_type([SampleName.adventure_works_lt]))

c.argument('license_type',
arg_type=get_enum_type(DatabaseLicenseType))
Expand Down

0 comments on commit 72a7e1f

Please sign in to comment.