[Network]Bump to azure-mgmt-network 9.0.0 #11989
Conversation
mmyyrroonn
force-pushed
the
fix-network-pe-pls
branch
from
11f880a
to
0eb77d7
Compare
|
add to S165. |
| @@ -77,7 +77,9 @@ def list_express_route_circuits(cmd, resource_group_name=None): | |||
|
|
|||
| def create_express_route_auth(cmd, resource_group_name, circuit_name, authorization_name): | |||
| client = network_client_factory(cmd.cli_ctx).express_route_circuit_authorizations | |||
| return client.create_or_update(resource_group_name, circuit_name, authorization_name) | |||
| ExpressRouteCircuitAuthorization = cmd.get_models('ExpressRouteCircuitAuthorization') | |||
There was a problem hiding this comment.
ExpressRouteCircuitAuthorization has two fields. I tried to expose these two in our command UX, however, during my test I cannot set any of them. The server will set both of two properties.
| @@ -2510,7 +2512,7 @@ def update_private_endpoint_connection(cmd, resource_group_name, service_name, p | |||
| connection_state = PrivateLinkServiceConnectionState( | |||
| status=connection_status, | |||
| description=description, | |||
| action_required=action_required | |||
| actions_required=action_required | |||
There was a problem hiding this comment.
This is the actual fix
| @@ -122,9 +122,10 @@ def test_network_private_endpoints(self, resource_group): | |||
|
|
|||
| pe_connection_name = self.cmd('network private-link-service show -g {rg} -n {lks1}').get_output_in_json()['privateEndpointConnections'][0]['name'] | |||
| self.kwargs['pe_connect'] = pe_connection_name | |||
| self.cmd('network private-link-service connection update -g {rg} -n {pe_connect} --service-name {lks1} --connection-status Rejected') | |||
| self.cmd('network private-link-service connection update -g {rg} -n {pe_connect} --service-name {lks1} --connection-status Rejected --action-required "need action"') | |||
There was a problem hiding this comment.
this is the test
|
Need to upgrade other related commands' YAML recording? |
|
@haroldrandom I didn't bump the api-version. so I don't think we should re-run the test. |
But azure-mgmt-network==9.0.0 use API string 2019-11-01 while azure-mgmt-network==7.0.0 use 2019-09-01, Doesn't it matter? |
no. I'm still using 2019-09-01. I didn't bump the api-version |
|
/azp run Run Automation Reduced Python 3.6 |
|
No pipelines are associated with this pull request. |
|
/azp run Azure.azure-cli |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.azure-cli (Run Automation Reduced Python 3.8) |
|
No pipelines are associated with this pull request. |
|
/azp run Azure.azure-cli |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mmyyrroonn
force-pushed
the
fix-network-pe-pls
branch
from
0eb77d7
to
5430ef4
Compare
|
/azp run Azure.azure-cli |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fix #11988
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.