{Core} Fix get_msal_token for beta by directly using MSAL #17147
+41
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
evelyn-ys,
fengzhou-msft,
houk-ms,
jsntcy and
Juliehzl
as code owners
|
Core |
jiasli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
get_msal_tokenfor beta.The current beta talks to Azure Identity to get VM SSH cert (#16596).
Due to Azure Identity's
kwargs(data) toget_tokenfor user account (Support CAE in azure-identity azure-sdk-for-python#16323 (comment))kwargs(data) toget_tokenfor service principal ([Identity] Let GetTokenMixin.get_token pass kwargs to MSAL azure-sdk-for-python#16397)Azure CLI now directly interacts with MSAL to retrieve the SSH certificate.
The process can be further improved by adopting #17072, #17093.