[AKS] az aks command invoke: Add progress spinner
#30274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CustardTart32
requested review from
zhoxing-ms,
jsntcy,
yanzhudd,
jiasli,
evelyn-ys,
kairu-ms,
calvinhzy,
necusjz and
bebound
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @CustardTart32, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
yonzhan and
FumingZhang
microsoft-github-policy-service
bot
added
Auto-Assign
|
@microsoft-github-policy-service agree company="Microsoft" |
CustardTart32
commented
Nov 7, 2024
FumingZhang
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Queued live test to validate the change, test passed!
- test_aks_run_command
CustardTart32
force-pushed
the
czhong/feat/run-command-status-poller
branch
from
12712f0
to
67b9c42
Compare
FumingZhang
approved these changes
Nov 8, 2024
CustardTart32
force-pushed
the
czhong/feat/run-command-status-poller
branch
2 times, most recently
from
75d5f38
to
7bbfe83
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
please fix the title with impacted command/parameter, e.g., |
|
Thanks @CustardTart32 , this is first step on AKS to show more details on long running operations, to improve customer experience. here I capture a gif using asciinema, you can see the Later we are going to apply this to |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
CustardTart32
force-pushed
the
czhong/feat/run-command-status-poller
branch
from
dbe98d0
to
2c2b08e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
previously approved these changes
Nov 12, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Nov 12, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…eterminateProgressBar
CustardTart32
force-pushed
the
czhong/feat/run-command-status-poller
branch
from
2c2b08e
to
a590c05
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
approved these changes
Nov 13, 2024
atombrella
pushed a commit
to atombrella/azure-cli
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks command invoke
Description
This PR adds a spinner and progress message to the
az aks command invokeCLI command, which can take several minutes to complete.Testing Guide
History Notes
[AKS]
az aks command invoke: Add progress spinnerThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.