[Internal] Client Telemetry: Fixes loggers (#4594)

* fix logger * skipping latency record if it is in negative otherwise histogram will throw an exception, while recording it * fix loggers
Azure · Jul 24, 2024 · 0f3e6ca · 0f3e6ca
1 parent 9de654e
commit 0f3e6ca
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/Microsoft.Azure.Cosmos/src/Telemetry/ClientTelemetry.cs b/Microsoft.Azure.Cosmos/src/Telemetry/ClientTelemetry.cs
@@ -221,7 +221,7 @@ internal static async Task RunProcessorTaskAsync(string telemetryDate, Task proc
                 Task resultTask = await Task.WhenAny(processingTask, delayTask);
                 if (resultTask == delayTask)
                 {
-                    DefaultTrace.TraceError($"Processor task with date as {0} is cancelled as it did not finish in {1} milliseconds", telemetryDate, timeout.TotalMilliseconds);
+                    DefaultTrace.TraceError("Processor task with date as {0} is cancelled as it did not finish in {1} milliseconds", telemetryDate, timeout.TotalMilliseconds);
                 }
                 else
                 {
@@ -244,12 +244,12 @@ internal void PushCacheDatapoint(string cacheName, TelemetryInformation data)
             // If latency information is not available. Ignore this datapoint. It is not expected but putting this safety check
             if (!data.RequestLatency.HasValue)
             {
-                DefaultTrace.TraceWarning($"Latency data point is not available for {0} cache call", cacheName);
+                DefaultTrace.TraceWarning("Latency data point is not available for {0} cache call", cacheName);
 
                 return;
             }
 
-            DefaultTrace.TraceVerbose($"Collecting cacheRefreshSource {0} data for Telemetry.", cacheName);
+            DefaultTrace.TraceVerbose("Collecting cacheRefreshSource {0} data for Telemetry.", cacheName);
 
             string regionsContacted = ClientTelemetryHelper.GetContactedRegions(data.RegionsContactedList);
 
@@ -322,7 +322,7 @@ internal void PushOperationDatapoint(TelemetryInformation data)
             }
             else
             {
-                DefaultTrace.TraceWarning($"Latency data point is not available for an operation");
+                DefaultTrace.TraceWarning("Latency data point is not available for an operation");
             }
 
             long requestChargeToRecord = (long)(data.RequestCharge * ClientTelemetryOptions.HistogramPrecisionFactor);

diff --git a/Microsoft.Azure.Cosmos/src/Telemetry/Collector/TelemetryCollector.cs b/Microsoft.Azure.Cosmos/src/Telemetry/Collector/TelemetryCollector.cs
@@ -42,7 +42,7 @@ public void CollectCacheInfo(string cacheName, Func<TelemetryInformation> functi
             }
             catch (Exception ex)
             {
-                DefaultTrace.TraceError($"Error while collecting cache {0} telemetry. Exception : {1}", cacheName, ex);
+                DefaultTrace.TraceError("Error while collecting cache {0} telemetry. Exception : {1}", cacheName, ex);
             }
         }
 
@@ -63,7 +63,7 @@ public void CollectOperationAndNetworkInfo(Func<TelemetryInformation> functionFo
             }
             catch (Exception ex)
             {
-                DefaultTrace.TraceError($"Error while collecting operation telemetry. Exception : {1}", ex);
+                DefaultTrace.TraceError("Error while collecting operation telemetry. Exception : {0}", ex);
             }
         }
 

diff --git a/Microsoft.Azure.Cosmos/src/Telemetry/TelemetryToServiceHelper.cs b/Microsoft.Azure.Cosmos/src/Telemetry/TelemetryToServiceHelper.cs
@@ -249,7 +249,7 @@ private void StopClientTelemetry()
             }
             catch (Exception ex)
             {
-                DefaultTrace.TraceWarning($"Error While stopping Telemetry Job : {0}", ex);
+                DefaultTrace.TraceWarning("Error While stopping Telemetry Job : {0}", ex);
             }   
         }
     }

diff --git a/Microsoft.Azure.Cosmos/src/Telemetry/VmMetadataApiHandler.cs b/Microsoft.Azure.Cosmos/src/Telemetry/VmMetadataApiHandler.cs
@@ -98,11 +98,11 @@ static ValueTask<HttpRequestMessage> CreateRequestMessage()
 
                 azMetadata = await VmMetadataApiHandler.ProcessResponseAsync(response);
 
-                DefaultTrace.TraceInformation($"Succesfully get Instance Metadata Response : {0}", azMetadata.Compute.VMId);
+                DefaultTrace.TraceInformation("Successfully get Instance Metadata Response : {0}", azMetadata.Compute.VMId);
             }
             catch (Exception e)
             {
-                DefaultTrace.TraceInformation($"Azure Environment metadata information not available. {0}", e.Message);
+                DefaultTrace.TraceInformation("Azure Environment metadata information not available. {0}", e.Message);
             }
         }
 
@@ -167,7 +167,7 @@ internal static string GetCloudInformation()
             }
             catch (Exception ex)
             {
-                DefaultTrace.TraceWarning($"Error while generating hashed machine name {0}", ex.Message);
+                DefaultTrace.TraceWarning("Error while generating hashed machine name {0}", ex.Message);
             }
 
             return $"{VmMetadataApiHandler.UuidPrefix}{Guid.NewGuid()}";
-Original file line number
+Diff line change
@@ Expand Up / @@ -249,7 +249,7 @@ private void StopClientTelemetry() @@
                 }
                 catch (Exception ex)
                 {
-                    DefaultTrace.TraceWarning($"Error While stopping Telemetry Job : {0}", ex);
+                    DefaultTrace.TraceWarning("Error While stopping Telemetry Job : {0}", ex);
                 }
             }
         }
@@ Expand Down @@