Query : Fixes ORDER BY query issue when partial partition key is specified with hierarchical partition #4507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com/Azure/azure-cosmos-dotnet-v3 into users/adityasa/HierarchicalPKOrderByIssue
adityasa
requested review from
khdang,
sboshra,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
Maya-Painter
approved these changes
May 20, 2024
kirankumarkolli
approved these changes
May 21, 2024
adityasa
added a commit
that referenced
this pull request
Jun 7, 2024
…ified with hierarchical partition (#4507) * Initial commit * Initial commit * Update.
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
If partial partition key is specified during query execution and the container partition is split at the top level of the partition key, ORDER BY query results may be wrong. This happens because query is incorrectly treated as a streaming ORDER BY query, even though it spans across multiple physical partitions. The fix is to ensure cross-partition ORDER BY pipeline gets used, which applies global sort on results obtained from each backend partition (using k-way merge). Since the physical partitions are already resolved by the time this determination is made (they just happen to get ignored at the moment), the fix is straightforward and bulk of the change is test related.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4472