Query: Fixes plumbing VectorEmbeddingPolicy to ServiceInterop to choose correct default distance function #4538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neildsh
requested review from
khdang,
sboshra,
adityasa,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
neildsh
force-pushed
the
users/ndeshpan/deafultDistFunc
branch
from
31a62ec to
82c72dd
Compare
Maya-Painter
approved these changes
Jun 10, 2024
microsoft-github-policy-service
bot
deleted the
users/ndeshpan/deafultDistFunc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change plumbs the vector embedding policy to the service interop so that the query plan is generated with the correct default distance function when non is specified in the query by the user
Type of change