-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Telemetry: Fixes attribute name following otel convention #4765
Open Telemetry: Fixes attribute name following otel convention #4765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Just some encouragement to provide more explicit context on why these changes are important.
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Tracing/AssertActivity.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Tracing/AssertActivity.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Tracing/AssertActivity.cs
Outdated
Show resolved
Hide resolved
a6f3081
to
4aedd08
Compare
...s/Microsoft.Azure.Cosmos.Encryption.Custom.Tests/Contracts/DotNetSDKEncryptionCustomAPI.json
Outdated
Show resolved
Hide resolved
4f23195
to
1b42f26
Compare
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryAttributeKeys.cs
Outdated
Show resolved
Hide resolved
The proposal looks good to me! There is a caveat that we can't update OTel semantic conventions with this:
because of some tooling/process issues. I'm working on addressing them, but in the meantime we'll need to either hold back this part of the change or be inconsistent with what's documented in the OTel today until tooling problems are resolved. |
What's the timeline for tooling readiness? |
8cff9df
to
d9a96a2
Compare
edeb94f
to
e49571c
Compare
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/AppInsightClassicAttributeKeys.cs
Show resolved
Hide resolved
We discussed this with @lmolkova and estimated that tool readiness would take about one month. However, we agreed it's not a high-priority task, as we're comfortable with the current naming, provided the OpenTelemetry community accepts it. We would, however, be hesitant to make changes in the future. |
Description
What is the change?
db.cosmosdb.operation_type
--> removed (moved to classic sdk support)db.cosmosdb.machine_id
--> removed (moved to classic sdk support)db.cosmosdb.client_id
-->it will remain samedb.cosmosdb.client.id
(aligns with OTel messaging conventions)db.cosmosdb.request_content_length
-->it will remain samedb.cosmosdb.request.content_length
(aligns with OTel HTTP conventions)db.cosmosdb.response_content_length
-->it will remain samedb.cosmosdb.request.content_length
(aligns with OTel HTTP conventions)db.cosmosdb.status_code
-->db.response.status_code
(moveddb.cosmosdb.status_code
to classic sdk support)db.cosmosdb.consistency_level
-> addeddb.cosmosdb.request_content_length_bytes
-> added for classic sdk supportWhy?
Lot of discussions are going on with Azure Core and Open Telemetry Community teams. As part of that discussion, we are making these changes as our goal is to be Open Telemetry and Azure compliant,
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4553