Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Pipelines: Fixes FaultInjection Release Pipelines #4913

Merged
merged 8 commits into from
Nov 28, 2024
Merged

[Internal] Pipelines: Fixes FaultInjection Release Pipelines #4913

merged 8 commits into from
Nov 28, 2024

Conversation

NaluTripician
Copy link
Contributor

@NaluTripician NaluTripician commented Nov 28, 2024 •
edited
Loading

Pull Request Template

Description

Fixes FaultInjection Release Pipelines:

  • Removes build-fault-injection-test.yml, this file is unneeded and including it just runs the same tests twice increasing cogs
  • Updates FaultInjection Tests, these tests were originally made using a session consistency account, the live account we use for integration testing in running with strong consistency. Changes to the tests needed to be made in order for them to run on strong consistency.
    image

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue: closes #IssueNumber

@NaluTripician NaluTripician added the auto-merge Enables automation to merge PRs label Nov 28, 2024
@NaluTripician NaluTripician self-assigned this Nov 28, 2024
@NaluTripician
Update fault-injection-nuget-pack.yml
f267f3e 
rename some of the stages
kundadebdatta
kundadebdatta previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach a screenshot of the successful publish stage, as well as a link to the pipeline. LGTM overall!

FabianMeiswinkel
FabianMeiswinkel approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thx

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 7b4128a into master Nov 28, 2024
25 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/nalutripician/fiReleasePipelineFix branch November 28, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kundadebdatta kundadebdatta kundadebdatta approved these changes

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie Pilchie is a code owner

Assignees

@NaluTripician NaluTripician

Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NaluTripician @FabianMeiswinkel @kundadebdatta