Change Feed Processor with Datetime.MinValue and Multi master accounts #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausfeldt
previously approved these changes
Nov 1, 2019
j82w
reviewed
Nov 20, 2019
kirankumarkolli
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Multi master accounts don't support the
If-Modified-Sinceheader. WhenWithStartTime(DateTime.MinValue.ToUniversalTime())was used in the Change Feed Processor with a Multi master account, it failed.With this PR, if
DateTime.MinValue.ToUniversalTime()is used to indicate "From the start of time/beginning", we will use the behavior of not specifyingIf-Modified-Sinceand not specifyingIf-None-Match, which uses the old StartFromBeginning.Type of change
Closing issues
Closes #938