-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update spelling baseline #4163
Conversation
Add some missing words to our custom dictionary to get the linter clean again.
@@ -2,9 +2,13 @@ AADSTS | |||
ABRT | |||
aiomysql | |||
aiopg | |||
aistudio | |||
alexwolf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of this is already in the config. Like: https://github.com/Azure/azure-dev/blob/main/cli/azd/.vscode/cspell.yaml#L39
Some cases are covered per file only.
Did you create this based on https://github.com/Azure/azure-dev/actions/runs/10207492464/job/28242344666?pr=4160 ? I think there's something going on with cspell. I'm looking into it |
Yeah, looks like there's some sort of regression on cspell 8.13.0 (released 3 days ago) https://github.com/streetsidesoftware/cspell/releases/tag/v8.13.0. Using |
Created an issue for cspell: streetsidesoftware/cspell#6025 |
See: #4164 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding request-changes only b/c I saw auto-merge :P
There is a bug on latest cspell lib, we should pin one version before until they fix it, instead of updating all the dictionaries. See: #4164
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Sounds good, I'll change to pin cspell. |
Pull request was closed
Add some missing words to our custom dictionary to get the linter clean again.