rpc: Support handlers of any arity #4630
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellismg
commented
Dec 14, 2024
| @@ -28,7 +28,7 @@ func newAspireService(server *Server) *aspireService { | |||
| // GetAspireHostAsync is the server implementation of: | |||
| // ValueTask<AspireHost> GetAspireHostAsync(Session session, string aspireEnv, CancellationToken cancellationToken). | |||
| func (s *aspireService) GetAspireHostAsync( | |||
| ctx context.Context, rc RequestContext, aspireEnv string, observer IObserver[ProgressMessage], | |||
| ctx context.Context, rc RequestContext, aspireEnv string, observer *IObserver[ProgressMessage], | |||
There was a problem hiding this comment.
It's non-obvious from the diff why I went and did this. The issues that IObserver needs some special attention during unmarshalling. The way that works is we have an internal interface:
// connectionObserver is an interface that can be implemented by types that want to be notified when they are deserialized
// during a JSON RPC call.
type connectionObserver interface {
attachConnection(c jsonrpc2.Conn)
}When we unmarshall arguments, we check to see if the type we unmarshalled to implements this interface and if so, we call it. IObserver's implementation of the method stores the connection so it can send messages to it later, as items are emitted.
The interface is implemented on *IObserver[T] not IObserver[T].
The old version of unmarshalArg handled this by adding a level of indirection on thet ype during interface checking:
if v, ok := (any(&arg)).(connectionObserver); ok {
v.attachConnection(conn)
}But it felt cleaner to not do this extra level of indirection in the new version and instead ensure the argument was just *IObserver[T].
There was a problem hiding this comment.
I can image that we could also do both - check to see if T and *T implement the interface, (preferring one if both are there) and calling the function.
ellismg
force-pushed
the
ellismg/make-rpc-handler-generic
branch
from
40e6c3f to
26c4363
Compare
ellismg
force-pushed
the
ellismg/make-rpc-handler-generic
branch
from
26c4363 to
92112c9
Compare
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.