Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate reviewers email ids discarded #1208

Merged
merged 8 commits into from
Sep 24, 2021
Merged

Duplicate reviewers email ids discarded #1208

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1d4b53d
Fixed
roshan-sy Sep 20, 2021
d689b54
None checked
roshan-sy Sep 20, 2021
dacddce
reviewers none checked
roshan-sy Sep 20, 2021
a3d79ee
Unit test added
roshan-sy Sep 21, 2021
14f17a9
call arg checked
roshan-sy Sep 24, 2021
ea5b55d
More specific check
roshan-sy Sep 24, 2021
adb926a
Check
roshan-sy Sep 24, 2021
850e165
test removed from
roshan-sy Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions azure-devops/azext_devops/dev/repos/pull_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ def create_pull_request(project=None, repository=None, source_branch=None, targe
if pr.source_ref_name == pr.target_ref_name:
raise CLIError('The source branch, "{}", can not be the same as the target branch.'.format
(pr.source_ref_name))
if reviewers is not None:
reviewers = list(set(x.lower() for x in reviewers))
pr.reviewers = _resolve_reviewers_as_refs(reviewers, organization)
if work_items is not None and work_items:
resolved_work_items = []
Expand Down