Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wiki page requires if match header in the request #533

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

atbagga
Copy link
Collaborator

@atbagga atbagga commented Apr 14, 2019

Updating a wiki page requires the version to be given as if-match header.
The client does not support it so adding it in the client for now.

This will need to be fixed in the Azure-Devops-python client. I will separately follow up on that.

@atbagga atbagga self-assigned this Apr 14, 2019
Copy link
Contributor

@gauravsaralMs gauravsaralMs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, how was it working earlier?
are we adding any recording test for this?

@atbagga
Copy link
Collaborator Author

atbagga commented Apr 15, 2019

Just curious, how was it working earlier?
are we adding any recording test for this?

Wasn't working. I missed testing the command since I kept it in PR for long time waiting for API version upgrade.
I will add the tests after a bug bash for these.

@atbagga atbagga merged commit a1c79b1 into master Apr 15, 2019
@atbagga atbagga deleted the users/atbagga/wikifix branch May 29, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants