Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CosmosDBOptions to allow configuration of the CosmosDB service client via CosmosClientOptions #2514

Closed
wants to merge 4 commits into from

Conversation

liliankasem
Copy link
Member

Issue describing the changes in this PR

resolves #2450

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR - TBD: need to check if document the default being Gateway
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests) - TODO

Additional information

Implement CosmosDBOptions for the cosmos extension that will expose CosmosClientOptions and allow users to configure the CosmosClient.

Breaking Change

Due to the default value for ConnectionMode in CosmosClientOptions being Direct, this change will introduce a breaking change for users who rely on the implicit default connection mode being Gateway. Currently, this extension has defaulted to using Gateway a the connection mode. Now that we are exposing CosmosClientOptions, we cannot differentiate between a user explicitly setting the connection mode to Direct and the SDK's default value of Direct. Therefore, we have to default to the SDK's default value.

If there are alternative approaches to this, please let me know!

@liliankasem liliankasem closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cosmos Extension] Implement missing configuration options
1 participant