Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Prep #2580

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Release Prep #2580

merged 1 commit into from
Jul 8, 2024

Conversation

satvu
Copy link
Member

@satvu satvu commented Jul 8, 2024 •
edited
Loading

Issue describing the changes in this PR

Release prep for SDK 1.17.3 and Sdk.Generators 1.3.1

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

fabiocav
fabiocav requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but can you please update the PR description with the details and remove placeholder text?

@satvu satvu requested a review from fabiocav July 8, 2024 20:59
@satvu satvu merged commit 005f9dc into main Jul 8, 2024
29 checks passed
@satvu satvu deleted the satvu/release-prep branch July 8, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviau jviau jviau approved these changes

@fabiocav fabiocav fabiocav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satvu @fabiocav @jviau