Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivityTraceFlags propagation #2608

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Conversation

RohitRanjanMS
Copy link
Member

Issue describing the changes in this PR

Adding support for ActivityTraceFlags and TraceState propagation from incoming requests involves ensuring that when a new Activity is created, it correctly inherits the trace context from an incoming request.

resolves #2543

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@RohitRanjanMS RohitRanjanMS changed the title Roranjan/trace flag propagation ActivityTraceFlags propagation Jul 17, 2024
Copy link
Contributor

@jviau jviau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the public setter for TraceStateString

src/DotNetWorker.Core/Diagnostics/ActivityExtensions.cs Outdated Show resolved Hide resolved
@RohitRanjanMS RohitRanjanMS merged commit 18a5b11 into main Jul 17, 2024
29 checks passed
@RohitRanjanMS RohitRanjanMS deleted the roranjan/TraceFlagPropagation branch July 17, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants