Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceBusSessionMessageActions not working with IsBatched=true for ServiceBusReceivedMessage #2889

Merged
merged 17 commits into from
Dec 17, 2024

Conversation

aishwaryabh
Copy link
Contributor

@aishwaryabh aishwaryabh commented Dec 6, 2024

Issue describing the changes in this PR

resolves #2873

When we have isBatched set to true and we have multiple ServiceBusReceivedMessage instances bound, the property that we receive from the binding data for the ServiceBusSessionMesasgeActions type is called SessionIdArray instead of SessionId. This PR accounts for that use case. I also removed the need for supporting deferred binding for ServiceBusSessionMessageActions[] as the SDK does not support this use case in the binding contract in ServiceBusTriggerBindingStrategy.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@aishwaryabh aishwaryabh requested a review from Copilot December 6, 2024 00:50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • test/Worker.Extensions.Tests/ServiceBus/ServiceBusSessionMessageActions.cs: Evaluated as low risk
  • test/Worker.Extensions.Tests/ServiceBus/ServiceBusMessageActionsTests.cs: Evaluated as low risk
Comments skipped due to low confidence (1)

test/Worker.Extensions.Tests/ServiceBus/ServiceBusSessionMessageConverterTests.cs:123

  • [nitpick] The test case name should be more descriptive. Consider renaming it to ConvertAsync_Batch_ForReceivedMessage_ReturnsFailed_DueToMultipleSessionIds.
public async Task ConvertAsync_Batch_ForReceivedMessage_ReturnsFailed_MultipleMessages()
@aishwaryabh aishwaryabh merged commit 05b4207 into main Dec 17, 2024
58 checks passed
@aishwaryabh aishwaryabh deleted the aibhandari/batched-service-bus branch December 17, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServiceBusSessionMessageActions not working with IsBatched=true
5 participants