Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing .suspend / .resume definitions in durableClient.d.ts #608

Open
evanlouie opened this issue Jun 28, 2024 · 5 comments
Open

Missing .suspend / .resume definitions in durableClient.d.ts #608

evanlouie opened this issue Jun 28, 2024 · 5 comments
Labels
help wanted Extra attention is needed P2 Priority 2 item

Comments

@evanlouie
Copy link

Describe the bug

Looks like suspend/resume support was landed in 3.1.0 (#578) but durableClient.d.ts has not been updated to show the new methods.

Expected behavior

I should be able to see .suspend .resume on the DurableClient when coding in TypeScript

Actual behavior

Compiler cannot see .suspend and .resume because the d.ts file hasn't been updated.

@evanlouie
Copy link
Author

Is there a reason why to use "declaration": false in the tsconfig.json? Seems like this sort of problem would be solved by having tsc automatically emit them and setting "types": "lib/src/index.d.ts" in package.json.

@davidmrdavid
Copy link
Collaborator

cc/ @erizba in case you have cycles.

@evanlouie I think we disabled tsc automatically emitting types to avoid the opposite problem: too many internally types being exposed, some by accident. In this case that's bitten us, but we've also been bit by the opposite behavior.

@bachuv bachuv added P2 Priority 2 item and removed Needs: Triage 🔍 labels Oct 2, 2024
@jasonvangundy
Copy link

This is biting me right now as well. I have the perfect use case for suspending and resuming my orchestrations but am unable to use the built-in functionality at present. 🤞 this is coming soon.

@jasonvangundy
Copy link

Actually, is there any ETA on this? I was considering implementing this on my own using custom events, but I would much prefer to use the built-in functionality. Of course because it's code I don't have to write, but we also get a lot of value out of the orchestration status changing. If I implement this as a custom event, I lose the ability to inspect the state change, both on suspend and resume. If the original issue was correct, it seems like this is just a published types issue and not actually missing / new functionality required, and hopefully low-hanging fruit. Thanks!

@cgillum cgillum added the help wanted Extra attention is needed label Oct 23, 2024
@jasonvangundy
Copy link

jasonvangundy commented Oct 24, 2024

A couple of other hopefully useful notes, presumably missing for the same reasons:

  1. HttpManagementPayload returned from createHttpManagementPayload does not contain the definitions for the suspendPostUri nor the resumePostUri.
  2. OrchestrationRuntimeStatus does not contain the statuses for Resumed and Suspended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed P2 Priority 2 item
Projects
None yet
Development

No branches or pull requests

5 participants