Add suspend/resume support #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I need to merge this change to branch v2.x too? I am not sure if this branch is still in support |
|
v2 is in support yes, but we generally only ship new features on the latest version. So no, I would not merge to v2 |
davidmrdavid
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
LGTM, though let's make sure to give proper credits to @Julio-Arroyo in the release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled. Please add @Julio-Arryo as contributor in the release notes.
This PR merges work contribtued by @Julio-Arryo in PR #376. His forked repo is too outdated and couldn't be auto merged. And the target branch of the old PR is outdated too. So I opened this one instead.