Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ts and pass audit #375

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Update ts and pass audit #375

merged 3 commits into from
Aug 5, 2022

Conversation

davidmrdavid
Copy link
Collaborator

@davidmrdavid davidmrdavid commented Aug 2, 2022

The CI has been failing with Node16 apparently due to some unmet dependency of ts-doc, which required a newer version of the typescript dev-dependency.

This PR updates our typescript dev-dependency, and also performs an npm audit fix

@davidmrdavid davidmrdavid changed the title update ts and pass audit Update ts and pass audit Aug 2, 2022
@davidmrdavid
Copy link
Collaborator Author

@hossam-nasr: FYI

Try running a CI on dev and you'll see that it fails due to some conflict on Node16. The step that's failing is npm ci.
This PR fixes that step, but now we fail at the building/testing stage

@davidmrdavid davidmrdavid marked this pull request as ready for review August 5, 2022 16:53
@davidmrdavid davidmrdavid merged commit f9a9045 into dev Aug 5, 2022
@davidmrdavid davidmrdavid deleted the dajusto/update-deps branch August 5, 2022 18:30
Julio-Arroyo added a commit to Julio-Arroyo/azure-functions-durable-js that referenced this pull request Aug 5, 2022
Update ts and pass audit (Azure#375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants