Adding runtime site name to valid JWT audiences (slot scenarios) #10183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
approved these changes
May 24, 2024
jviau
approved these changes
May 24, 2024
src/WebJobs.Script.WebHost/Security/Authentication/Jwt/ScriptJwtBearerExtensions.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/Security/Authentication/Jwt/ScriptJwtBearerExtensions.cs
Outdated
Show resolved
Hide resolved
mathewc
force-pushed
the
audience-slot-fix
branch
from
1a626ff to
e9aeee4
Compare
mathewc
force-pushed
the
audience-slot-fix
branch
from
e9aeee4 to
1dde153
Compare
mathewc
added a commit
that referenced
this pull request
May 24, 2024
This was referenced May 24, 2024
mathewc
added a commit
that referenced
this pull request
May 24, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis of production logs reveal that in slot scenarios, audience validation for JWT tokens can fail, because platform components like DataRole and ScaleController when talking to non-production slots for the site will send an audience value using the runtime site name, so would use audience "https://testsite__5bb5.azurewebsites.net". Whereas, the normal production slot audience for this site is "https://testsite.azurewebsites.net".
I will be backporting this to v3 and v1.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.md