Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking SyncTriggers [RequiresRunningHost] (#9904) #10225

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

mathewc
Copy link
Member

@mathewc mathewc commented Jun 11, 2024

Addresses #9904. Recently in PR #9898 we enforced a running host for FlexConsumption sync trigger operations, which allowed us to reliably include extended host config info in the sync payload. It was a TODO to address this for all SKUs after we reviewed the metrics we added in that PR (host.synctriggers.hostnotinitialized) to determine how safe the change would be.

The metric has been out for several releases now, and we now have data showing that about 98% of sync operations are performed on a running host already (query below).

Will backport to in-proc as well.

let _start = ago(3h);
let syncTriggersTotalCount = toscalar(All("FunctionsMetrics")
| where PreciseTimeStamp > _start
| where parse_version(HostVersion) >= parse_version("4.33.2.2")
| where EventName == "host.synctriggers.invoke"
| summarize sum(Count));
let nonInitializedSyncCount = toscalar(All("FunctionsMetrics")
| where PreciseTimeStamp > _start
| where EventName =~ "host.synctriggers.hostnotinitialized"
| summarize sum(Count));
print UnInitializedSyncPercentage=100*round((1.0*nonInitializedSyncCount)/syncTriggersTotalCount, 4);

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@mathewc mathewc requested a review from a team as a code owner June 11, 2024 23:14
@mathewc mathewc force-pushed the sync-triggers-running-host branch from 61aaaf4 to 5ae99f9 Compare June 12, 2024 19:10
@chiangvincent chiangvincent self-requested a review June 12, 2024 22:44
@mathewc mathewc force-pushed the sync-triggers-running-host branch 2 times, most recently from ce64b8c to 3e80af2 Compare June 13, 2024 22:06
@mathewc mathewc force-pushed the sync-triggers-running-host branch from 3e80af2 to 1097388 Compare June 14, 2024 00:24
@mathewc mathewc merged commit f138d7c into dev Jun 14, 2024
14 checks passed
@mathewc mathewc deleted the sync-triggers-running-host branch June 14, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants