Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant DiagnosticEvents error message #10395

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

RohitRanjanMS
Copy link
Member

@RohitRanjanMS RohitRanjanMS commented Aug 13, 2024

Adding a validation check for the storage connection string. If the connection string is null, empty, or invalid, diagnostic events will not be written to table storage, and the service will be disabled. This will help reduce noise in the FunctionsLogs table caused by exceptions thrown due to an invalid or empty connection string.

resolves #10163

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@RohitRanjanMS RohitRanjanMS merged commit 51dc962 into dev Aug 20, 2024
10 checks passed
@RohitRanjanMS RohitRanjanMS deleted the roranjan/DiagnosticEvent branch August 20, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host unable to write diagnostics events to table storage if app is configured with managed identity
3 participants