-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using hostMetadataProvider for CreateOrUpdate call in FunctionController #10678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soninaren
changed the title
efrUsing hostMetadataProvider for CreateOrUpdate call in FunctionController
Using hostMetadataProvider for CreateOrUpdate call in FunctionController
Dec 6, 2024
soninaren
force-pushed
the
nasoni/forceRefresh2
branch
from
December 6, 2024 22:29
eb93b3a
to
48fa447
Compare
liliankasem
reviewed
Dec 6, 2024
liliankasem
approved these changes
Dec 7, 2024
kshyju
reviewed
Dec 9, 2024
kshyju
approved these changes
Dec 9, 2024
mathewc
reviewed
Dec 10, 2024
mathewc
reviewed
Dec 10, 2024
mathewc
reviewed
Dec 10, 2024
mathewc
reviewed
Dec 10, 2024
mathewc
reviewed
Dec 10, 2024
mathewc
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
We encountered 500s from the CreateUpdate flow from FunctionController. This was caused because of multiple host restarts that used to happen during this flow. @fabiocav fixed host restarts in this PR. However we still had one remaining when forceRefresh was set to true. This caused the function host to restart and resulted in 500s. The forceRefresh caused host restart while fetching the metadata from function workers. However in this flow we do not need to fetch the metadata from the workers. So to resolve this we are directly using HostMetadataProvider. This prevents the restart and still gives us fresh metadata as we reading the function files again.
Resolves #10631
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
Additional PR information