Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using hostMetadataProvider for CreateOrUpdate call in FunctionController #10678

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

soninaren
Copy link
Member

@soninaren soninaren commented Dec 6, 2024

Issue describing the changes in this PR

We encountered 500s from the CreateUpdate flow from FunctionController. This was caused because of multiple host restarts that used to happen during this flow. @fabiocav fixed host restarts in this PR. However we still had one remaining when forceRefresh was set to true. This caused the function host to restart and resulted in 500s. The forceRefresh caused host restart while fetching the metadata from function workers. However in this flow we do not need to fetch the metadata from the workers. So to resolve this we are directly using HostMetadataProvider. This prevents the restart and still gives us fresh metadata as we reading the function files again.

Resolves #10631

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@soninaren soninaren requested a review from a team as a code owner December 6, 2024 21:00
@soninaren soninaren changed the title efrUsing hostMetadataProvider for CreateOrUpdate call in FunctionController Using hostMetadataProvider for CreateOrUpdate call in FunctionController Dec 6, 2024
@soninaren soninaren force-pushed the nasoni/forceRefresh2 branch from eb93b3a to 48fa447 Compare December 6, 2024 22:29
@soninaren soninaren merged commit 2d8bd38 into dev Dec 11, 2024
11 checks passed
@soninaren soninaren deleted the nasoni/forceRefresh2 branch December 11, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Functions Host 1036 results in a 500 Error on a PUT to /admin/functions
4 participants