[pack] extension bundle probing and download #4043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soninaren
requested review from
pragnagopa and
fabiocav
and removed request for
pragnagopa
|
@soninaren / @SatishRanjan - Coincidentally we have two features which require probing directories for dependencies. It makes sense to define a common interface for both of them. @fabiocav - thoughts? |
fabiocav
reviewed
Feb 6, 2019
src/WebJobs.Script/BindingExtensionBundle/ExtensionBundleManager.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/BindingExtensionBundle/ExtensionBundleManager.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/BindingExtensionBundle/ExtensionBundleOptionsSetup.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/BindingExtensionBundle/ExtensionBundleOptionsSetup.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/BindingExtensionBundle/ExtensionBundleOptionsSetup.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/BindingExtensionBundle/ExtensionBundleManager.cs
Outdated
Show resolved
Hide resolved
pragnagopa
reviewed
Feb 15, 2019
test/WebJobs.Script.Tests/Configuration/ExtensionBundleOptionsSetupTest.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/BindingExtensionBundle/ExtensionBundleOptionsSetup.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/BindingExtensionBundle/ExtensionBundleOptionsSetup.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/BindingExtensionBundle/IExtensionBundleManager.cs
Outdated
Show resolved
Hide resolved
soninaren
changed the title
pragnagopa
reviewed
Feb 21, 2019
pragnagopa
reviewed
Feb 21, 2019
pragnagopa
reviewed
Feb 21, 2019
There was a problem hiding this comment.
Overall looks good. Added few comments. Mostly nits.
@fabiocav - Please take a look at IScriptStartupTypeLocatorFactory changes
src/WebJobs.Script/DependencyInjection/ScriptStartupTypeLocator.cs
Outdated
Show resolved
Hide resolved
|
@pragnagopa @brettsam @alrod working on a review here, but it would be good to have your feedback |
pragnagopa
reviewed
Feb 21, 2019
pragnagopa
approved these changes
Feb 21, 2019
fabiocav
reviewed
Feb 22, 2019
src/WebJobs.Script/BindingExtensionBundle/ExtensionBundleManager.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/DependencyInjection/IScriptStartupTypeLocatorFactory.cs
Outdated
Show resolved
Hide resolved
|
@fabiocav have addressed the PR comments. Let me know if there are any more changes. |
|
Closing this one and opening this one instead #4135. We can reiterate the new PR. This would allow me to create draft PR's that build on top of the branch from the new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3961
Resolves #3711