-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for customHandler section in host.json #6064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please hold off on this while we discuss #6020? Thanks. |
Yes. I will hold off. Added comments in referenced issue. This PR would still be needed to support env vars in the existing config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments from a brief look.
e478325
to
fcac40e
Compare
src/WebJobs.Script/Workers/Http/Configuration/HttpWorkerOptions.cs
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
c1e18b3
to
d9d2d06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/WebJobs.Script/Workers/Http/Configuration/HttpWorkerOptions.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/Workers/Http/Configuration/HttpWorkerOptionsSetup.cs
Outdated
Show resolved
Hide resolved
d9d2d06
to
ab4b5d0
Compare
@yojagad - can you please take quick a look again as I had to resolve few merge conflicts |
@fabiocav - can you please take a look at the config |
That was the only comment I had. Rest looks good! |
This PR adds support to specify custom handler section in host.json as discussed in #6080
host.json
that specifiesworkingDirectory
description
following the format%EnvVarName%
. Here is an exampledescription
can also be overridden via EnvVars/AppSettings. Here is an example of AppSetting / Environment variable name to overrride arguments elementAzureFunctionsJobHost:customHandler:description:arguments
Fixes #5692, Fixes #5921, Fixes #5547, Fixes #6080, Fixes #5882, Fixes #5615
Note: httpWorker section will be deprecated sometime later. For now, it is still supported.