Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip external config validation if RuntimeDrivenScaling is enabled in Elastic Premium #7085

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

soninaren
Copy link
Member

@soninaren soninaren commented Jan 22, 2021

Issue describing the changes in this PR

Function host was throwing a host initialization exception when an configuration from external source was used in a trigger binding. The validation / exception was invalid when Runtime driven scaling was enabled for function app was hosted on elastic premium hosting plan. The change here is skips the validation for this specific case.

resolves #6542

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Copy link
Member

@brettsam brettsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to test this out before/after in a private site extension?

@soninaren
Copy link
Member Author

Were you able to test this out before/after in a private site extension?

Yes, i tested with private site extension.

@soninaren soninaren merged commit 8b927a9 into dev Jan 26, 2021
@soninaren soninaren deleted the developer/nasoni/rtsvalidator branch January 26, 2021 23:18
@fabiocav fabiocav restored the developer/nasoni/rtsvalidator branch March 23, 2021 23:38
@fabiocav fabiocav deleted the developer/nasoni/rtsvalidator branch June 25, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow External Startup to update the config when Runtime Scale Monitoring is enabled
2 participants