Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map WebJobs Extension RPC data sources onto the gRPC host endpoints #9292

Merged
merged 8 commits into from
Jun 13, 2023

Conversation

jviau
Copy link
Contributor

@jviau jviau commented May 24, 2023

This PR is to a feature branch. The intention is to review, check in, build & release feature branch to internal feed. After testing and validation by partners, we will then merge feature branch into dev.

This PR consumes the new Microsoft.Azure.WebJobs.Rpc.Core package (from our ADO feed for now), which brings in a single contract WebJobsRpcEndpointDataSource. This type is used by WebJobs extensions via the Microsoft.Azure.WebJobs.Extensions.Rpc package to register and export their RPC extensions (only gRPC supported at this time). We then discover all of those data sources from the active script host and map them into the existing AspNetCore server we use for our own gRPC communication between host and worker. The end result here is that WebJobs extensions can easily hand off their gRPC service implementations to us for endpoint mapping. This enables custom RPC scenarios between worker and host.

Issue describing the changes in this PR

resolves #9291

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR -- TODO in another PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@jviau jviau changed the base branch from dev to feature/rpc-preview June 8, 2023 17:52
@jviau jviau marked this pull request as ready for review June 8, 2023 17:57
@jviau jviau requested a review from a team as a code owner June 8, 2023 17:57
@jviau jviau requested a review from liliankasem June 12, 2023 17:30
@jviau jviau merged commit 69a9a58 into Azure:feature/rpc-preview Jun 13, 2023
@jviau jviau deleted the ext-channel branch June 13, 2023 16:42
@jviau jviau mentioned this pull request Jul 13, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map WebJobs RPC extensions onto the gRPC host
3 participants