Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply capabilities correctly on reload #9367

Merged
merged 14 commits into from
Jul 26, 2023
Merged

Apply capabilities correctly on reload #9367

merged 14 commits into from
Jul 26, 2023

Conversation

satvu
Copy link
Member

@satvu satvu commented Jul 5, 2023 •
edited
Loading

Issue describing the changes in this PR

resolves #9366

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional Information

7/6 blocked on design and standardization of how capabilities received in placeholder mode and/or after specialization are combined and applied.

@satvu satvu requested a review from brettsam July 5, 2023 22:19
@satvu satvu marked this pull request as ready for review July 6, 2023 21:15
@satvu satvu requested a review from a team as a code owner July 6, 2023 21:15
@satvu satvu added the blocked label Jul 6, 2023
@satvu satvu mentioned this pull request Jul 7, 2023
Merged
@satvu satvu force-pushed the satvu/apply-capabilities-fix branch from b8cc993 to 2067c7c Compare July 19, 2023 21:49
@satvu satvu removed the blocked label Jul 19, 2023
@brettsam brettsam mentioned this pull request Jul 24, 2023
Closed
@satvu satvu requested review from kshyju, brettsam and liliankasem July 25, 2023 19:00
@satvu satvu force-pushed the satvu/apply-capabilities-fix branch from 7fd00b7 to e30ccbc Compare July 26, 2023 16:50
@satvu satvu closed this Jul 26, 2023
@satvu satvu reopened this Jul 26, 2023
@satvu satvu requested review from kshyju and surgupta-msft July 26, 2023 21:58
@satvu @liliankasem
Update test/DotNetIsolated60/DotNetIsolated60.csproj storage extension
d9f38f7 
Co-authored-by: Lilian Kasem <likasem@microsoft.com>
@satvu satvu merged commit 6ebfee4 into dev Jul 26, 2023
@satvu satvu deleted the satvu/apply-capabilities-fix branch July 26, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliankasem liliankasem liliankasem approved these changes

@brettsam brettsam brettsam approved these changes

@kshyju kshyju Awaiting requested review from kshyju

@surgupta-msft surgupta-msft Awaiting requested review from surgupta-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EnvironmentReloadResponse not updating all Capabilities
5 participants
@satvu @kshyju @brettsam @liliankasem @surgupta-msft