sending an empty rpchttp to worker when proxying #9415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When http proxying is enabled, there's no need to send the http payload over grpc as well. This PR short-circuits the generation of the grpc payload and returns a static, empty RpcHttp object if we know we're proxying the request.
Note that we still send the entry in the dictionary that maps to the trigger -- but it's effectively a placeholder. This is just in case any worker depends on this entry being present.
Pull request checklist
release_notes.md