Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sending an empty rpchttp to worker when proxying #9415

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

brettsam
Copy link
Member

@brettsam brettsam commented Jul 24, 2023

When http proxying is enabled, there's no need to send the http payload over grpc as well. This PR short-circuits the generation of the grpc payload and returns a static, empty RpcHttp object if we know we're proxying the request.

Note that we still send the entry in the dictionary that maps to the trigger -- but it's effectively a placeholder. This is just in case any worker depends on this entry being present.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@brettsam brettsam requested a review from a team as a code owner July 24, 2023 15:51
@brettsam brettsam merged commit 388c4d2 into dev Jul 24, 2023
@brettsam brettsam deleted the brettsam/minimal_rpchttp branch July 24, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants