Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend http proxying timeout #9433

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Extend http proxying timeout #9433

merged 4 commits into from
Aug 4, 2023

Conversation

satvu
Copy link
Member

@satvu satvu commented Aug 2, 2023

Issue describing the changes in this PR

resolves #1745 in dotnet worker.

Default yarp timeout is 100 seconds (docs) which is shorter than the Antares default for HTTP requests (230s) so we need to set our own default value.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Filed an issue for http timeout test suite here.

@satvu satvu requested a review from brettsam August 2, 2023 04:33
@satvu satvu marked this pull request as ready for review August 3, 2023 16:48
@satvu satvu requested a review from a team as a code owner August 3, 2023 16:48
@satvu satvu requested a review from kshyju August 3, 2023 19:17
@satvu satvu merged commit a3187f1 into dev Aug 4, 2023
@satvu satvu deleted the satvu/yarp-timeout branch August 4, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASP.NET Core integration HttpRequest timeout
3 participants