Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workload identity support #9480

Merged
merged 7 commits into from
Sep 6, 2023
Merged

Conversation

aishwaryabh
Copy link
Contributor

@aishwaryabh aishwaryabh commented Aug 22, 2023

Issue describing the changes in this PR

This PR allows us to authenticate with managed identity when hosting a function on an AKS cluster and using a workload identity credential as part of the connection to the Azure storage account.

These are the dependency changes:

Changed:
- Azure.Core.dll: 1.25.0.0/1.2500.22.33004 -> 1.34.0.0/1.3400.23.36203
- Azure.Identity.dll: 1.4.1.0/1.400.121.40406 -> 1.10.0.0/1.1000.23.41405
- Microsoft.Extensions.Azure.dll: 1.1.1.0/1.100.121.45201 -> 1.7.0.0/1.700.23.40801
- Microsoft.Identity.Client.dll: 4.30.1.0/4.30.1.0 -> 4.54.1.0/4.54.1.0
- Microsoft.Identity.Client.Extensions.Msal.dll: 2.18.4.0/2.18.4.0 -> 2.31.0.0/2.31.0.0

Removed:

Added:
- System.Diagnostics.DiagnosticSource.dll: 6.0.0.0/6.0.1523.11507

resolves #9266

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@aishwaryabh aishwaryabh marked this pull request as ready for review August 25, 2023 17:42
@aishwaryabh aishwaryabh requested review from fabiocav, brettsam, mathewc and a team as code owners August 25, 2023 17:42
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aishwaryabh can you please share the full list of impacted dependencies?

This would be part of the test output if you run the deps validation with the original version of the deps.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants