Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Santize from MetricsLogger hotpath #9489

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Remove Santize from MetricsLogger hotpath #9489

merged 3 commits into from
Aug 28, 2023

Conversation

pragnagopa
Copy link
Member

@pragnagopa pragnagopa commented Aug 25, 2023 •
edited
Loading

Issue describing the changes in this PR

resolves #9490

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@pragnagopa pragnagopa requested a review from mathewc August 25, 2023 17:17
@pragnagopa pragnagopa requested a review from a team as a code owner August 25, 2023 17:17
@pragnagopa pragnagopa requested review from fabiocav and jviau August 28, 2023 15:21
@pragnagopa pragnagopa merged commit 6a08852 into dev Aug 28, 2023
@pragnagopa pragnagopa deleted the pgopa/removesanitizefromhotpath branch August 28, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathewc mathewc mathewc approved these changes

@kshyju kshyju kshyju approved these changes

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio

@fabiocav fabiocav Awaiting requested review from fabiocav

@jviau jviau Awaiting requested review from jviau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Sanitize from MetricsLogger hotpath
3 participants
@pragnagopa @kshyju @mathewc