Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making JWT token audience/issuer validation case insensitive. #9684

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

mathewc
Copy link
Member

@mathewc mathewc commented Nov 14, 2023

Backport of #9678. In the v1 port, I didn't carry the logging forward because the version of the token libraries we're using in v1 make it easy to log PII when logging token validation exceptions (e.g. will log the raw token). Later library versions being used in v3/v4 do not output PII.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@mathewc mathewc force-pushed the token-validation-v1 branch from 0ab2058 to 27d3810 Compare November 15, 2023 00:24
@mathewc mathewc requested a review from a team November 15, 2023 15:44
@mathewc mathewc merged commit bb5abe9 into v1.x Nov 15, 2023
2 checks passed
@mathewc mathewc deleted the token-validation-v1 branch November 15, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants