Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function group to metadata and sync triggers #9735

Closed
wants to merge 6 commits into from

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Dec 11, 2023

Issue describing the changes in this PR

resolves #9732

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

This PR adds function grouping calculation as an extension method FunctionMetadata.GetFunctonGroup(). Function grouping is included in sync-triggers payload if it is non-null. Function grouping calculation works as follows:

  1. If FunctionMetadata.Properties["FunctionGroup"] is present, return that.
  2. Else, check if HTTP or Durable trigger. Return http or durable respectively.
  3. Return null if none of the above checks succeed.

Some additional changes include binding & function metadata extensions refactoring.

@jviau jviau requested a review from a team as a code owner December 11, 2023 18:22
@jviau jviau force-pushed the jviau/func-group branch from 87ae6b1 to bed295e Compare January 4, 2024 19:04
@jviau jviau requested a review from mathewc January 4, 2024 19:06
@jviau
Copy link
Contributor Author

jviau commented Jan 5, 2024

Checks appear to be stuck - can't restart them either (web page locks up). Going to close and re-open the PR.

@jviau jviau closed this Jan 5, 2024
@jviau jviau reopened this Jan 5, 2024
@jviau jviau closed this Jan 5, 2024
@jviau jviau reopened this Jan 5, 2024
@liliankasem
Copy link
Member

@jviau I think there is an actual failure:

/home/runner/work/azure-functions-host/azure-functions-host/test/WebJobs.Script.Tests/Extensions/FunctionMetadataExtensionsTests.cs(198,49): error CS7036: There is no argument given that corresponds to the required parameter 'isFlexConsumption' of 'FunctionMetadataExtensions.ToFunctionTrigger(FunctionMetadata, ScriptJobHostOptions, bool)'

@jviau jviau force-pushed the jviau/func-group branch from fa8ae66 to 78bb606 Compare January 8, 2024 18:52
@jviau
Copy link
Contributor Author

jviau commented Jan 8, 2024

Will re-create PR with branch on this repo.

@jviau jviau closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flex][Scaling] Add function grouping information
4 participants