Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an app setting to allow CORS configuration #9846

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Conversation

soninaren
Copy link
Member

@soninaren soninaren commented Jan 31, 2024

resolves #8936

Host currently honors 'CORS_ALLOWED_ORIGINS' app setting only for linux consumption. Windows and linux app service go thorugh a seperate channel. However there are additional hosting scenarios that have no way of setting up CORS configuration. This change adds an app setting that allows customer to set up CORS configuration by setting "FUNCTIONS_ENABLE_CORS_CONFIGURATION" = "true"

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@soninaren soninaren requested a review from a team as a code owner January 31, 2024 12:48
Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions, otherwise LGTM.

src/WebJobs.Script/Environment/EnvironmentSettingNames.cs Outdated Show resolved Hide resolved
src/WebJobs.Script/Environment/EnvironmentExtensions.cs Outdated Show resolved Hide resolved
release_notes.md Show resolved Hide resolved
@soninaren soninaren merged commit 49732b0 into dev Feb 1, 2024
9 checks passed
@soninaren soninaren deleted the nasoni/CorsUpdate branch February 1, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CORS configuration via environment variables when not running in Linux consumption
4 participants