Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assign permissions when file does not exist #9982

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Do not assign permissions when file does not exist #9982

merged 3 commits into from
Apr 10, 2024

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Apr 8, 2024

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Avoids polluting logs with warning messages when the process path does not exist.

@jviau jviau requested a review from a team as a code owner April 8, 2024 19:22
@jviau jviau merged commit 5553d7c into dev Apr 10, 2024
9 checks passed
@jviau jviau deleted the jviau/permissions-verbosity branch April 10, 2024 16:17
jviau added a commit that referenced this pull request Apr 10, 2024
@jviau
Do not assign permissions when file does not exist (#9982)
e1ff488 
* Do not assign permissions when file does not exist

* Fix unit tests

* Fix unit tests
@jviau jviau mentioned this pull request Apr 10, 2024
Merged
jviau added a commit that referenced this pull request Apr 11, 2024
@jviau
Do not assign permissions when file does not exist (#9982) (#9988)
68bbaa9 
* Do not assign permissions when file does not exist

* Fix unit tests

* Fix unit tests
RohitRanjanMS pushed a commit that referenced this pull request Apr 12, 2024
@jviau @RohitRanjanMS
Do not assign permissions when file does not exist (#9982)
109cccd 
* Do not assign permissions when file does not exist

* Fix unit tests

* Fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliankasem liliankasem liliankasem approved these changes

@kshyju kshyju kshyju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jviau @kshyju @liliankasem