Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary ServiceLoader load logic #614

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Conversation

kaibocai
Copy link
Member

Issue describing the changes in this PR

remove the unnecessary ServiceLoader load logic. It's duplicate logics as create db connection will call the spi logics.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@kaibocai
Copy link
Member Author

Hi @trask ,
@amamounelsayed mention that he worked with you on adding this loadDriver logics. We just found it's not necessary as when customer create the DB connection, the spi logics will be executed, example here. So the logic seems doing the duplicate works.

@kaibocai kaibocai requested a review from trask August 12, 2022 18:35
@kaibocai kaibocai merged commit 8b2a459 into dev Aug 15, 2022
@kaibocai kaibocai deleted the kaibocai/remove-loaddriver branch August 15, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants