Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable placeholders to start with app insights agent using profiles #656

Merged
merged 8 commits into from
Sep 23, 2022
Merged

Enable placeholders to start with app insights agent using profiles #656

merged 8 commits into from
Sep 23, 2022

Conversation

shreyas-gopalakrishna
Copy link
Member

@shreyas-gopalakrishna shreyas-gopalakrishna commented Sep 22, 2022 •
edited
Loading

  • Update worker.config.json to include profiles that enable and disable app insights
  • Downloads the application insights agent as part of java worker. This includes changes to bring the agent in the java worker release package
  • AI agent version 3.4.0 used
  • APPLICATIONINSIGHTS_ENABLE_AGENT app setting to enable and disable across all SKUs

resolves #585

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

kaibocai
kaibocai reviewed Sep 22, 2022
View reviewed changes
worker.config.json Outdated Show resolved Hide resolved
@shreyas-gopalakrishna shreyas-gopalakrishna merged commit 5c9d454 into dev Sep 23, 2022
@shreyas-gopalakrishna shreyas-gopalakrishna deleted the shreyasg/distributed-tracing-1 branch September 23, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaibocai kaibocai kaibocai approved these changes

@amamounelsayed amamounelsayed amamounelsayed approved these changes

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Application insights agent will be part of the java worker
3 participants
@shreyas-gopalakrishna @amamounelsayed @kaibocai