Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spring cloud samples #707

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Update spring cloud samples #707

merged 5 commits into from
Mar 6, 2023

Conversation

kaibocai
Copy link
Member

Issue describing the changes in this PR

Update spring cloud samples

  1. update the samples with new denpendency injection pattern
  2. simplify the samples with new DI feature. Remove reactive samples as for now azure function java doesn't support it by far.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

kamperiadis
kamperiadis approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@kamperiadis kamperiadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @kaibocai

@kaibocai kaibocai merged commit 0ebfe09 into dev Mar 6, 2023
@kaibocai kaibocai deleted the kaibocai/update-spring-cloud-samples branch March 6, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamperiadis kamperiadis kamperiadis approved these changes

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed

@shreyas-gopalakrishna shreyas-gopalakrishna Awaiting requested review from shreyas-gopalakrishna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaibocai @kamperiadis