Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WorkerMetadata message to WorkerInitResponse #76

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Add WorkerMetadata message to WorkerInitResponse #76

merged 3 commits into from
Jun 15, 2022

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Jun 14, 2022 •
edited
Loading

Updating the protobuf to capture additional worker information required for telemetry.

Property format Description Examples
runtime_name The runtime/stack name Node, PowerShell, Java, .NET, .NET Framework, Python, etc.
runtime_version The version of the runtime/stack  Such as the version of .NET or Python etc.
worker_version The version of the worker  
worker_bitness The worker bitness/architecture x86, x64, arm64
custom_properties Additional worker specific custom properties Usage of custom containers vs first-party image containers, npm package, the version of the SDK used in .NET Isolated, etc.

@liliankasem liliankasem marked this pull request as ready for review June 14, 2022 18:08
kshyju
kshyju reviewed Jun 14, 2022
View reviewed changes
src/proto/FunctionRpc.proto Outdated Show resolved Hide resolved
kshyju
kshyju approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

This was referenced Jun 14, 2022
Closed
Closed
Closed
Closed
Closed
Francisco-Gamino
Francisco-Gamino approved these changes Jun 15, 2022
View reviewed changes
Copy link

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liliankasem liliankasem merged commit 9881137 into dev Jun 15, 2022
@liliankasem liliankasem mentioned this pull request Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pragnagopa pragnagopa pragnagopa left review comments

@kaibocai kaibocai kaibocai approved these changes

@gavin-aguiar gavin-aguiar gavin-aguiar approved these changes

@Francisco-Gamino Francisco-Gamino Francisco-Gamino approved these changes

@ejizba ejizba ejizba approved these changes

@kshyju kshyju kshyju approved these changes

@vrdmr vrdmr Awaiting requested review from vrdmr vrdmr is a code owner

@YunchuWang YunchuWang Awaiting requested review from YunchuWang YunchuWang is a code owner

@surgupta-msft surgupta-msft Awaiting requested review from surgupta-msft surgupta-msft is a code owner

@satvu satvu Awaiting requested review from satvu satvu is a code owner

@alrod alrod Awaiting requested review from alrod alrod is a code owner

@AnatoliB AnatoliB Awaiting requested review from AnatoliB AnatoliB is a code owner

@shreyas-gopalakrishna shreyas-gopalakrishna Awaiting requested review from shreyas-gopalakrishna shreyas-gopalakrishna is a code owner

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed amamounelsayed is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@liliankasem @kshyju @pragnagopa @ejizba @Francisco-Gamino @gavin-aguiar @kaibocai