Ensure timely exit of process after test run finishes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already call
process.exitif the test run failed (on line 43 which is cutoff in the diff), so I just updated the successful case to also callprocess.exit.Related to #28, since this will force clean up anything that wasn't cleaned up yet. I simulated this on my local machine by temporarily removing the calls to
client.close(since I couldn't actually repro the flaky timeouts on my local machine). Without my PR change the process will continue to run indefinitely because the clients are holding on to something (which is what leads to a timeout in a CI run) and with my PR change it exited immediately and worked great.