Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Entity Trigger #68

Merged
merged 8 commits into from
Sep 17, 2020
Merged

Added support for Entity Trigger #68

merged 8 commits into from
Sep 17, 2020

Conversation

davidmrdavid
Copy link
Contributor

The Durable Entities construct of Durable Functions uses a trigger binding type named entityTrigger. This PR makes a minimal change that enables entityTrigger to enable Durable Functions for Python to define Entities. This is will enable the following PR for Durable Functions in Python: Azure/azure-functions-durable-python#184

@davidmrdavid davidmrdavid requested review from Hazhzeng and vrdmr August 27, 2020 01:19
@Hazhzeng Hazhzeng self-requested a review August 28, 2020 18:50
@Hazhzeng
Copy link
Contributor

Hazhzeng commented Aug 28, 2020

Please import this EntityContext in azure/functions/__init__.py
https://github.com/Azure/azure-functions-python-library/blob/dev/azure/functions/__init__.py#L14

@vrdmr vrdmr requested a review from anirudhgarg as a code owner August 30, 2020 07:20
@vrdmr
Copy link
Member

vrdmr commented Aug 30, 2020

@davidmrdavid - Please add tests for the new type in here - test_durable_functions.py. Also, when this gets done, also add to the E2E tests in worker - the second piece will come in later but just FYI.

@vrdmr
Copy link
Member

vrdmr commented Sep 9, 2020

@davidmrdavid Any updates on this?

@davidmrdavid
Copy link
Contributor Author

@vrdmr , I haven't gotten around this yet because I was OOF last week and got a bit sidetracked with some other tasks today. I want to make this a priority for tomorrow though. I will be pinging you for a few clarifications on this in the morning, sorry for the delay! Just for my information, is this blocking a release?

@davidmrdavid
Copy link
Contributor Author

@Hazhzeng @vrdmr ,
Made the requested changes (exporting the EntityContext) and generalized the existing unit tests to account for the EntityContext as well.

@Hazhzeng , I also left a TODO on the existing unit tests as I realized that these two tests are identical. Please let me know if I'm missing something there.

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes - Let's have a quick session on how the EntityTrigger is used.

azure/functions/durable_functions.py Show resolved Hide resolved
@Hazhzeng Hazhzeng merged commit 7a31be1 into dev Sep 17, 2020
@Hazhzeng Hazhzeng deleted the dajusto/entityTrigger branch September 17, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants