-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Entity Trigger #68
Conversation
Please import this EntityContext in |
@davidmrdavid - Please add tests for the new type in here - test_durable_functions.py. Also, when this gets done, also add to the E2E tests in worker - the second piece will come in later but just FYI. |
@davidmrdavid Any updates on this? |
@vrdmr , I haven't gotten around this yet because I was OOF last week and got a bit sidetracked with some other tasks today. I want to make this a priority for tomorrow though. I will be pinging you for a few clarifications on this in the morning, sorry for the delay! Just for my information, is this blocking a release? |
@Hazhzeng @vrdmr , @Hazhzeng , I also left a TODO on the existing unit tests as I realized that these two tests are identical. Please let me know if I'm missing something there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes - Let's have a quick session on how the EntityTrigger is used.
The Durable Entities construct of Durable Functions uses a trigger binding type named
entityTrigger
. This PR makes a minimal change that enablesentityTrigger
to enable Durable Functions for Python to define Entities. This is will enable the following PR for Durable Functions in Python: Azure/azure-functions-durable-python#184