Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nuspec for v2 and v3 #1013

Merged
merged 1 commit into from
Apr 21, 2022
Merged

fix nuspec for v2 and v3 #1013

merged 1 commit into from
Apr 21, 2022

Conversation

arroyc
Copy link
Contributor

@arroyc arroyc commented Apr 21, 2022

Fix build by fixing v2 and v3 nuspec

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@@ -20,7 +20,7 @@
<file src="..\3.7_OSX_X64\**" target="tools\3.7\OSX\X64" />
<file src="..\python\prodV2\worker.config.json" target="tools" />
<file src="Microsoft.Azure.Functions.PythonWorker.targets" target="build" />
<file src="..\PythonWorker\_manifest\manifest.json" target="SBOM\manifest.json" />
<file src="..\PythonWorker\_manifest\spdx_2.2\manifest.spdx.json" target="SBOM\manifest.spdx.json" />
<file src="..\_manifest\manifest.json" target="SBOM\manifest.json" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For v4

<file src="..\_manifest\manifest.json" target="SBOM\manifest.json" />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for V3

<file src="..\_manifest\spdx_2.2\manifest.spdx.json" target="SBOM\manifest.spdx.json" />

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #1013 (0ba66a8) into release/3.1.3 (f499e49) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release/3.1.3    #1013   +/-   ##
==============================================
  Coverage          82.51%   82.51%           
==============================================
  Files                 33       33           
  Lines               1653     1653           
  Branches             265      265           
==============================================
  Hits                1364     1364           
  Misses               224      224           
  Partials              65       65           
Flag Coverage Δ
unittests 82.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f499e49...0ba66a8. Read the comment docs.

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the quick change.

@vrdmr vrdmr merged commit 15cc8e2 into release/3.1.3 Apr 21, 2022
@vrdmr vrdmr deleted the arroyc/fix-build-3.1.3 branch April 21, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants