Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enabling implicit output for generic bindings (#1348)" #1376

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

gavin-aguiar
Copy link
Contributor

This reverts commit a981fcf.

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6f40f1) 85.40% compared to head (c9d5584) 85.50%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1376      +/-   ##
==========================================
+ Coverage   85.40%   85.50%   +0.10%     
==========================================
  Files          35       35              
  Lines        1953     1953              
  Branches      370      370              
==========================================
+ Hits         1668     1670       +2     
+ Misses        214      213       -1     
+ Partials       71       70       -1     
Flag Coverage Δ
unittests 85.45% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gavin-aguiar gavin-aguiar reopened this Dec 2, 2023
@gavin-aguiar gavin-aguiar merged commit f269c09 into dev Dec 2, 2023
63 of 67 checks passed
@gavin-aguiar gavin-aguiar deleted the gaaguiar/revert_generic_bindings branch December 2, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants